Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4252 +/- ##
==========================================
+ Coverage 81.30% 81.31% +0.01%
==========================================
Files 671 671
Lines 43020 43086 +66
Branches 7138 7119 -19
==========================================
+ Hits 34976 35035 +59
- Misses 6877 6899 +22
+ Partials 1167 1152 -15 ☔ View full report in Codecov by Harness. |
Nateowami
force-pushed
the
fix/enable-nullable-warnings
branch
from
November 7, 2026 03:48
566314e to
3d91a8c
Compare
Nateowami
marked this pull request as ready for review
November 7, 2026 03:48
Nateowami
added
the
ai-review-author-sign-off
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
#nullable disable warningswhere it is possible to do so without breaking things, or where only very minor changes are needed.It introduces non-null assertions and marks some things as optional that were previously not marked as optional. However, in general this is merely making the code more honest about what is optional and when it is doing something the compiler can't prove is safe, NOT making something unsafe that was safe before.
The main benefit isn't to the code that is updated here, but the fact that lots of future code will be more strictly checked for type safety.
This change is